jolshan commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1322167160
##########
clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitResponse.java:
##########
@@ -47,6 +47,9 @@
* - {@link Errors#UNKNOWN_MEMBER_ID}
* - {@link Errors#FENCED_INSTANCE_ID}
* - {@link Errors#ILLEGAL_GENERATION}
+ * - {@link Errors#INVALID_TXN_STATE}
Review Comment:
There are some issues with these new errors. concurrent transactions,
invalid pid mapping and invalid txn state are fatal but would be better if they
were retriable (concurrent txns) or abortable (invalid pid mapping, invalid txn
state).
Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
