jolshan commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1330915798
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1048,7 +1048,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
if (duplicateBatch.isPresent) {
return (updatedProducers, completedTxns.toList,
Some(duplicateBatch.get()))
}
+ }
+ if (origin == AppendOrigin.CLIENT || origin ==
AppendOrigin.COORDINATOR) {
// Verify that if the record is transactional & the append origin is
client, that we either have an ongoing transaction or verified transaction
state.
Review Comment:
Good point. I will also update when David merges his change since it subtly
affects this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]