dajac commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1336429881
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -958,7 +959,8 @@ private[group] class GroupCoordinator(
producerEpoch: Short,
offsetMetadata:
immutable.Map[TopicIdPartition, OffsetAndMetadata],
requestLocal: RequestLocal,
- responseCallback:
immutable.Map[TopicIdPartition, Errors] => Unit): Unit = {
+ responseCallback:
immutable.Map[TopicIdPartition, Errors] => Unit,
+ transactionalId: String): Unit = {
Review Comment:
nit: ditto about the position.
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -4072,6 +4072,8 @@ class GroupCoordinatorTest {
val capturedArgument: ArgumentCaptor[scala.collection.Map[TopicPartition,
PartitionResponse] => Unit] =
ArgumentCaptor.forClass(classOf[scala.collection.Map[TopicPartition,
PartitionResponse] => Unit])
+ // Since transactional ID is only used in appendRecords, we can use a
dummy value. Ensure it passes through.
+ val transactionalId = producerId.toString
Review Comment:
ditto.
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -449,6 +452,10 @@ class GroupMetadataManager(brokerId: Int,
| Errors.INVALID_FETCH_SIZE =>
Errors.INVALID_COMMIT_OFFSET_SIZE
+ case Errors.INVALID_PRODUCER_ID_MAPPING
+ | Errors.INVALID_TXN_STATE =>
+ Errors.UNKNOWN_MEMBER_ID
Review Comment:
Could you please explain the rational behind using UNKNOWN_MEMBER_ID here?
We should also add a comment about it because this is not obvious.
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -901,6 +901,7 @@ private[group] class GroupCoordinator(
generationId: Int,
offsetMetadata: immutable.Map[TopicIdPartition,
OffsetAndMetadata],
responseCallback: immutable.Map[TopicIdPartition,
Errors] => Unit,
+ transactionalId: String,
Review Comment:
nit: Would it make sense to move `transactionalId` to right before
`producerId`/`producerEpoch`?
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -349,7 +351,8 @@ class GroupMetadataManager(brokerId: Int,
responseCallback: immutable.Map[TopicIdPartition, Errors]
=> Unit,
producerId: Long = RecordBatch.NO_PRODUCER_ID,
producerEpoch: Short = RecordBatch.NO_PRODUCER_EPOCH,
- requestLocal: RequestLocal = RequestLocal.NoCaching): Unit
= {
+ requestLocal: RequestLocal = RequestLocal.NoCaching,
+ transactionalId: String = null): Unit = {
Review Comment:
nit: ditto about the position.
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##########
@@ -311,9 +311,10 @@ class GroupCoordinatorConcurrencyTest extends
AbstractCoordinatorConcurrencyTest
}
lock.foreach(_.lock())
try {
+ // Since the replica manager is mocked we can use a dummy value for
transactionalId.
groupCoordinator.handleTxnCommitOffsets(member.group.groupId,
producerId, producerEpoch,
JoinGroupRequest.UNKNOWN_MEMBER_ID, Option.empty,
JoinGroupRequest.UNKNOWN_GENERATION_ID,
- offsets, callbackWithTxnCompletion)
+ offsets, callbackWithTxnCompletion, producerId.toString)
Review Comment:
nit: Would using `dummy-transaction-id` be better than using the producer id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
