cmccabe commented on code in PR #14312:
URL: https://github.com/apache/kafka/pull/14312#discussion_r1362559009


##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -244,6 +251,11 @@ boolean check() {
      */
     private final boolean zkMigrationEnabled;
 
+    /**
+     * True if eligible leader replicas is enabled.
+     */
+    private final boolean eligibleLeaderReplicasEnabled;

Review Comment:
   I don't see why this is in ClusterControlManager. It's not related to 
cluster membership -- seems related to replication, so it should go in 
ReplicationControlManager ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to