CalvinConfluent commented on code in PR #14312:
URL: https://github.com/apache/kafka/pull/14312#discussion_r1362774389


##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -434,6 +434,14 @@ Map<String, String> getConfigs(ConfigResource 
configResource) {
         }
     }
 
+    String getTopicConfig(String topicName, String configKey) {

Review Comment:
   - Now using the computeEffectiveTopicConfigs. getEffectiveTopicConfigValue 
is not in AK yet.
   - return null if the config is not found.
   - It will be a separate change to handle the ELR change if minISR is 
dynamically updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to