cmccabe commented on code in PR #14312:
URL: https://github.com/apache/kafka/pull/14312#discussion_r1362559786
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -434,6 +434,14 @@ Map<String, String> getConfigs(ConfigResource
configResource) {
}
}
+ String getTopicConfig(String topicName, String configKey) {
Review Comment:
This is not correct. If you want to know what the topic configuration is,
you have to use `getEffectiveTopicConfigValue`. This will handle things like
the N levels of config overrides.
I also don't agree with mapping "doesn't exist" to "empty string" (we don't
do that anywhere else in the code)
Finally, you'll need a strategy for handling changes to these dynamic
configurations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
