cmccabe commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362935412
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -186,7 +186,10 @@ public enum MetadataVersion { IBP_3_6_IV2(14, "3.6", "IV2", true), // Implement KIP-919 controller registration. - IBP_3_7_IV0(15, "3.7", "IV0", true); + IBP_3_7_IV0(15, "3.7", "IV0", true), + + // Add ELR related supports (KIP-966). + IBP_3_7_IV1(16, "3.7", "IV1", true); Review Comment: > Wouldn't having this prevent version bumps until KIP-966 is fully implemented Good question, but no, it shouldn't One thing to note, though: if we need a second MV bump before this feature fully works, we can point that out too (and/or enforce it somehow). Do you think this will be needed @CalvinConfluent ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org