ex172000 commented on code in PR #14729:
URL: https://github.com/apache/kafka/pull/14729#discussion_r1389423646
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -679,6 +679,9 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
def close(): Unit = {
beginShutdown()
thread.join()
+ if (!started) {
Review Comment:
Do we want to put the `started` as a parameter to the method to make it look
cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]