hudeqi commented on code in PR #14729:
URL: https://github.com/apache/kafka/pull/14729#discussion_r1395212845
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1373,6 +1384,9 @@ private[kafka] class Processor(
try {
beginShutdown()
thread.join()
+ if (!started) {
Review Comment:
Sorry, I described the wrong object. Please replace all the `SocketServer` I
described above with `Acceptor`. In fact, what I mean is: `serverChannel` and
`nioSelector` are closed in `closeAll`. There only be one of these two objects
in an `Acceptor`, so the redundancy I am talking about is for this link "The
SocketServer#shutdown calls Acceptor#beginShutdown, Acceptor#close", no matter
whether the thread of `Acceptor` is started or not, it will be executed to
`closeAll` (When started is true, `closeAll` is executed through finally, and
when it is false, `closeAll` will also be executed.) So, is there no need to do
extra `closeAll` at the `Processor` level? @gharris1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
