gharris1727 commented on code in PR #14729:
URL: https://github.com/apache/kafka/pull/14729#discussion_r1395204633
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1373,6 +1384,9 @@ private[kafka] class Processor(
try {
beginShutdown()
thread.join()
+ if (!started) {
Review Comment:
> What I mean is: when the thread of SocketServer does not get up, closeAll
will be executed through started as false
SocketServer doesn't have a closeAll or started field, it's in the Acceptor.
> then there is no need to execute closeAll once more in Processor, even if
Processor started in ` is also false?
Processor has a selector that needs to be closed, even if there are no
sockets attached.
I think I'm still not grasping what you're saying. Can you be more specific
with which function/line numbers you think are run twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
