gharris1727 commented on code in PR #14729:
URL: https://github.com/apache/kafka/pull/14729#discussion_r1389645226
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -679,6 +679,9 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
def close(): Unit = {
beginShutdown()
thread.join()
+ if (!started) {
Review Comment:
Hey @ex172000 thanks for the review! Do you mean as a parameter to closeAll?
I don't think that's necessary as started is an instance variable. Also, I
didn't add the condition to finally block because it should always be true at
that point in the code, so it's only present on this code path where the thread
has not been started yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
