philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1398541169
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -231,6 +243,17 @@ private void handleCoordinatorDisconnect(Throwable
exception, long currentTimeMs
}
}
+ @Override
+ public NetworkClientDelegate.PollResult pollOnClose() {
+ if (!pendingRequests.hasUnsentRequests() ||
!coordinatorRequestManager.coordinator().isPresent())
+ return EMPTY;
+
+ sendAutoCommit(subscriptions.allConsumed());
Review Comment:
We should take away the runAtClose one. Sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
