philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1398695558
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -192,10 +191,11 @@ static void runAtClose(final Collection<Optional<?
extends RequestManager>> requ
// Poll to ensure that request has been written to the socket. Wait
until either the timer has expired or until
// all requests have received a response.
- while (timer.notExpired() &&
!requestFutures.stream().allMatch(Future::isDone)) {
- networkClientDelegate.poll(timer.remainingMs(),
timer.currentTimeMs());
+ do {
Review Comment:
We need to make sure to at least poll the network client once, so switched
to do {} while
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
