philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1398693518
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -446,9 +485,11 @@ private void onFailure(final long currentTimeMs,
handleCoordinatorDisconnect(responseError.exception(),
currentTimeMs);
log.debug("Offset fetch failed: {}", responseError.message());
// TODO: should we retry on COORDINATOR_NOT_AVAILABLE as well ?
- if (responseError == COORDINATOR_LOAD_IN_PROGRESS ||
- responseError == Errors.NOT_COORDINATOR) {
+ if (responseError == COORDINATOR_LOAD_IN_PROGRESS) {
+ retry(currentTimeMs);
+ } else if (responseError == Errors.NOT_COORDINATOR) {
// re-discover the coordinator and retry
+ coordinatorRequestManager.markCoordinatorUnknown("error
response " + responseError.name(), currentTimeMs);
Review Comment:
this is a bug: we should markCoordinatorUnknown on error: `NOT_COORDINATOR`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
