satishd commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1413535522
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -299,7 +329,7 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
BrokerTopicStats.NoKeyCompactedTopicRecordsPerSec ->
MeterWrapper(BrokerTopicStats.NoKeyCompactedTopicRecordsPerSec, "requests"),
BrokerTopicStats.InvalidMagicNumberRecordsPerSec ->
MeterWrapper(BrokerTopicStats.InvalidMagicNumberRecordsPerSec, "requests"),
BrokerTopicStats.InvalidMessageCrcRecordsPerSec ->
MeterWrapper(BrokerTopicStats.InvalidMessageCrcRecordsPerSec, "requests"),
- BrokerTopicStats.InvalidOffsetOrSequenceRecordsPerSec ->
MeterWrapper(BrokerTopicStats.InvalidOffsetOrSequenceRecordsPerSec, "requests")
+ BrokerTopicStats.InvalidOffsetOrSequenceRecordsPerSec ->
MeterWrapper(BrokerTopicStats.InvalidOffsetOrSequenceRecordsPerSec, "requests"),
Review Comment:
Why is `,` required here?
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
meter.close()
}
- def close(): Unit = metricTypeMap.values.foreach(_.close())
+ def close(): Unit = {
+ metricTypeMap.values.foreach(_.close())
+ metricGaugeTypeMap.values.foreach(_.close())
+ }
+}
+
+class BrokerTopicAggregatedMetric() {
+ private val partitionMetricValues = collection.concurrent.TrieMap[Int,
Long]()
Review Comment:
Why is `TrieMap` used instead of `javautil.concurrent.ConcurrentHashMap`
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
