clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1408110951
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -283,8 +283,39 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
meter()
}
+ case class GaugeWrapper(metricType: String, brokerTopicAggregatedMetric:
BrokerTopicAggregatedMetric) {
+ @volatile private var lazyGauge: Gauge[Long] = _
+ private val gaugeLock = new Object
+
+ def gauge(): Gauge[Long] = {
Review Comment:
Good question, I believe this is a leftover from the meters. I have removed
it. I have further added to an integration test. To be honest, however, I
haven't found a nice way to simulate an upload to remote storage being blocked
to showcase the increase in this value via a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
