lucasbru commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1500408843
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
I suppose this was copied from the KIP, so it's a question of the protocol
specification. I don't think in the consumer implementation it can change. It
seems that either that a little imprecision in the protocol spec, or the
protocol allows changing/adding the instance ID in a running client. @dajac
probably knows which of the two it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
