lucasbru commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1500632283
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
I was wondering that as well. I wanted to get this out of the way to
stabilize the tests. It's not wrong for the client to send the instance ID
here. If we are worried, we can wait for David to come back from PTO. I
wouldn't want to just relax the requirements in the coordinator on my own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
