cadonna commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1500548287


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData() 
{
             data.setMemberEpoch(membershipManager.memberEpoch());
 
             // InstanceId - only sent if has changed since the last heartbeat

Review Comment:
   Might the fact that an group instance ID is required when leaving the group 
even be a mistake in the group coordinator?
   As far as I can see, the member epoch that is sent already contains the 
information that a static member leaves the group and the group coordinator 
should keep a mapping between member ID and group instance ID. Why is   the 
group instance ID required when leaving?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to