cadonna commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1500644733
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
I totally agree. I just mentioned it to start a discussion not to block this
PR or request immediate changes in the group coordinator.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRequestData()
{
data.setMemberEpoch(membershipManager.memberEpoch());
// InstanceId - only sent if has changed since the last heartbeat
Review Comment:
I totally agree. I just mentioned it to start a discussion, not to block
this PR or request immediate changes in the group coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
