cmccabe commented on code in PR #16670:
URL: https://github.com/apache/kafka/pull/16670#discussion_r1690280602
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2083,6 +2098,41 @@ private boolean handleApiVersionsResponse(
);
}
+ private CompletableFuture<RemoveRaftVoterResponseData>
handleRemoveVoterRequest(
+ RaftRequest.Inbound requestMetadata,
+ long currentTimeMs
Review Comment:
I guess this applies to addVoter as well, but we really should be using the
monotonic clock here, not the wall clock, in case someone adjusts the wall
clock.
Maybe should be done in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
