cmccabe commented on code in PR #16670:
URL: https://github.com/apache/kafka/pull/16670#discussion_r1690281338
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2083,6 +2098,41 @@ private boolean handleApiVersionsResponse(
);
}
+ private CompletableFuture<RemoveRaftVoterResponseData>
handleRemoveVoterRequest(
+ RaftRequest.Inbound requestMetadata,
+ long currentTimeMs
+ ) {
+ RemoveRaftVoterRequestData data = (RemoveRaftVoterRequestData)
requestMetadata.data();
+
+ if (!hasValidClusterId(data.clusterId())) {
+ return completedFuture(
+ new
RemoveRaftVoterResponseData().setErrorCode(Errors.INCONSISTENT_CLUSTER_ID.code())
Review Comment:
should we include a message saying that the cluster ID is inconsistent (such
as having our cluster ID and theirs?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
