jsancio commented on code in PR #16670:
URL: https://github.com/apache/kafka/pull/16670#discussion_r1690486320
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2083,6 +2098,41 @@ private boolean handleApiVersionsResponse(
);
}
+ private CompletableFuture<RemoveRaftVoterResponseData>
handleRemoveVoterRequest(
+ RaftRequest.Inbound requestMetadata,
+ long currentTimeMs
Review Comment:
Good point. Let me file a jira to revisit KRaft's source of time. In some
cases it needs to be a wall-clock. Like when it it is persisted to disk as the
leader's append time. But for the timers, it doesn't need to be based on a
wall-clock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
