jsancio commented on code in PR #16670:
URL: https://github.com/apache/kafka/pull/16670#discussion_r1690595619
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2083,6 +2098,41 @@ private boolean handleApiVersionsResponse(
);
}
+ private CompletableFuture<RemoveRaftVoterResponseData>
handleRemoveVoterRequest(
+ RaftRequest.Inbound requestMetadata,
+ long currentTimeMs
+ ) {
+ RemoveRaftVoterRequestData data = (RemoveRaftVoterRequestData)
requestMetadata.data();
+
+ if (!hasValidClusterId(data.clusterId())) {
+ return completedFuture(
+ new
RemoveRaftVoterResponseData().setErrorCode(Errors.INCONSISTENT_CLUSTER_ID.code())
Review Comment:
Sure. We don't do that for the other validation (RPC). Let me file an issue
to do that for all of the cluster id checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
