jolshan commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1711945486
########## clients/src/main/resources/common/message/ProduceRequest.json: ########## @@ -37,7 +37,9 @@ // Version 10 is the same as version 9 (KIP-951). // // Version 11 adds support for new error code TRANSACTION_ABORTABLE (KIP-890). - "validVersions": "0-11", + // + // Version 12 is the same as version 10 (KIP-890). Review Comment: Can we be a bit more specific here. Version 12 is for optimizing KIP-890 transactions. The produce request will also include an AddPartitionsToTxn call. etc. Ditto for the TxnOffsetCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
