CalvinConfluent commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719072601
########## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ########## @@ -86,7 +86,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRate = metricsGroup.newMeter(VerificationFailureRateMetricName, "failures", TimeUnit.SECONDS) private val verificationTimeMs = metricsGroup.newHistogram(VerificationTimeMsMetricName) - def verifyTransaction( + def addOrVerifyTransaction( Review Comment: Added a section in the replica manager callback to convert the error codes. ########## gradle/spotbugs-exclude.xml: ########## @@ -499,6 +499,14 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read <Bug pattern="IS2_INCONSISTENT_SYNC" /> </Match> + <Match> + <!-- Ignore spurious warning about coordinatorSupportsTransactionV2. During the initialization it does require Review Comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
