jolshan commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1711946815
########## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ########## @@ -86,7 +86,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRate = metricsGroup.newMeter(VerificationFailureRateMetricName, "failures", TimeUnit.SECONDS) private val verificationTimeMs = metricsGroup.newHistogram(VerificationTimeMsMetricName) - def verifyTransaction( + def addOrVerifyTransaction( Review Comment: For this file, we should double check that there are no new errors to produce/offsetCommit that can be returned by the adding partition path. If there are, we may wan to consider converting them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
