CalvinConfluent commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1719071137
##########
clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitRequest.java:
##########
@@ -93,7 +118,8 @@ public TxnOffsetCommitRequest build(short version) {
throw new UnsupportedVersionException("Broker doesn't support
group metadata commit API on version " + version
+ ", minimum supported request version is 3 which requires
brokers to be on version 2.5 or above.");
}
- return new TxnOffsetCommitRequest(data, version);
+
+ return new TxnOffsetCommitRequest(data, (short)
Math.min(desiredMaximumVersion, version));
Review Comment:
Added the same thing to the produce request.
##########
clients/src/main/resources/common/message/ProduceRequest.json:
##########
@@ -37,7 +37,9 @@
// Version 10 is the same as version 9 (KIP-951).
//
// Version 11 adds support for new error code TRANSACTION_ABORTABLE
(KIP-890).
- "validVersions": "0-11",
+ //
+ // Version 12 is the same as version 10 (KIP-890).
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
