chia7712 commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1718539536
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -95,13 +96,33 @@ public Builder setTargetTimes(List<ListOffsetsTopic>
topics) {
@Override
public ListOffsetsRequest build(short version) {
+ for (ListOffsetsTopic topic : data.topics()) {
+ for (ListOffsetsPartition partition : topic.partitions()) {
+ checkVersion(version, topic.name(), partition);
Review Comment:
@frankvicky Could you please add a helper to build invalid request in order
to run test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
