Re: [PR] KAFKA-17331: Throw UnsupportedVersionException if the data in ListOffsetRequest does NOT fit EarliestLocalSpec and LatestTieredSpec. [kafka]

[via GitHub]

FrankYang0529 commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1720775844


##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -65,7 +66,8 @@ public static Builder forReplica(short allowedVersion, int 
replicaId) {
         public static Builder forConsumer(boolean requireTimestamp,
                                           IsolationLevel isolationLevel,
                                           boolean requireMaxTimestamp,
-                                          boolean 
requireTieredStorageTimestamp) {
+                                          boolean 
requireTieredStorageTimestamp,
+                                          List<ListOffsetsTopic> topics) {

Review Comment:
   Yes, we should update this. Thanks @chia7712 and @frankvicky 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org