chia7712 commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1720990975
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java:
##########
@@ -93,13 +94,38 @@ ListOffsetsRequest.Builder buildBatchedRequest(int
brokerId, Set<TopicPartition>
.stream()
.anyMatch(key -> offsetTimestampsByPartition.get(key) ==
ListOffsetsRequest.MAX_TIMESTAMP);
+ boolean requireEarliestLocalTimestamp = keys
+ .stream()
+ .anyMatch(key -> offsetTimestampsByPartition.get(key) ==
ListOffsetsRequest.EARLIEST_LOCAL_TIMESTAMP);
+
boolean requireTieredStorageTimestamp = keys
Review Comment:
Could you please move this "helper" to `ListOffset.Builder`? normally, we
should not use this helper as it requires to "loop" data. However, if callers
have no idea about the "timestamp" type, this helper can find out that for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
