frankvicky commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1718550335
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -95,13 +96,33 @@ public Builder setTargetTimes(List<ListOffsetsTopic>
topics) {
@Override
public ListOffsetsRequest build(short version) {
+ for (ListOffsetsTopic topic : data.topics()) {
+ for (ListOffsetsPartition partition : topic.partitions()) {
+ checkVersion(version, topic.name(), partition);
Review Comment:
Hi @FrankYang0529 and @chia7712
I have reviewed the code. Since this error is due to a version check in the
build method, I will change `assertEqual` to `assertThrows` when the test tries
to build an invalid request to align with the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
