dajac commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1719827276
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -580,6 +563,23 @@ object ConfigCommand extends Logging {
}
}
+ private def alterResourceConfig(adminClient: Admin, entityTypeHead: String,
entityNameHead: String, configsToBeDeleted: Seq[String], configsToBeAdded:
Map[String, ConfigEntry], resourceType: ConfigResource.Type): Unit = {
+ val oldConfig = getResourceConfig(adminClient, entityTypeHead,
entityNameHead, includeSynonyms = false, describeAll = false)
Review Comment:
I thought about this do while review the describe PR. It is a bit tricky
because the controller does not know whether the group really exists or not.
Only the group coordinator does know this information. This is why I leaned
towards returning the default static configs in this case. This is not wrong
because the group could be create any time and it is, it would have those
configurations by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
