chia7712 commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1721014948
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -580,6 +563,23 @@ object ConfigCommand extends Logging {
}
}
+ private def alterResourceConfig(adminClient: Admin, entityTypeHead: String,
entityNameHead: String, configsToBeDeleted: Seq[String], configsToBeAdded:
Map[String, ConfigEntry], resourceType: ConfigResource.Type): Unit = {
+ val oldConfig = getResourceConfig(adminClient, entityTypeHead,
entityNameHead, includeSynonyms = false, describeAll = false)
Review Comment:
> This is not wrong because the group could be create any time and it is, it
would have those configurations by default.
My concern was the consistency. The type `TOPIC` has similar attributes but
we return exception if it is nonexistent [0]. However, maybe we can add enough
docs to the APIs to remind users
[0]
https://github.com/apache/kafka/blob/c5e91546721b6b160732667ca7450d22927cc3b3/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L1513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
