chia7712 commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1723342987
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -544,6 +615,18 @@ private void verifyPerBrokerConfigValue(Admin client,
}, 5000, config + " are not updated");
}
+ private void verifyDeletedGroupConfig(Admin client,
Review Comment:
According to
https://github.com/apache/kafka/pull/16887#discussion_r1719827276, we are
always able to see the group configs. Hence, we should check that the value is
revert to "default value" after we delete the configs.
##########
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##########
@@ -824,6 +828,13 @@ private synchronized Config
getResourceDescription(ConfigResource resource) {
}
return toConfigObject(clientMetricsConfigs.get(resourceName));
}
+ case GROUP: {
+ String resourceName = resource.name();
+ if (resourceName.isEmpty()) {
+ throw new InvalidRequestException("Empty resource name");
+ }
+ return toConfigObject(groupConfigs.get(resourceName));
Review Comment:
Should we align the behavior to return "default configs" even though the
group is nonexistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
