AndrewJSchofield commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1719887934
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -562,6 +543,8 @@ object ConfigCommand extends Logging {
adminClient.describeCluster(new
DescribeClusterOptions()).nodes().get().asScala.map(_.idString).toSeq :+
BrokerDefaultEntityName
case ConfigType.CLIENT_METRICS =>
adminClient.listClientMetricsResources().all().get().asScala.map(_.name).toSeq
+ case ConfigType.GROUP =>
+ adminClient.listConsumerGroups(new
ListConsumerGroupsOptions().withTypes(Seq(GroupType.CONSUMER).toSet.asJava)).all.get.asScala.map(_.groupId).toSeq
Review Comment:
@chia7712 Group configs can be applied to all groups. KIP-932 introduces 5
new group configs which I expect to deliver in the coming days. For example,
isolation level for a share group is a group-level config configured with
`group.share.isolation.level`.
KIP-1043 would enable you to list groups of all types in a cleaner way
because it introduces `AdminClient.listGroups()`. The thing I struggle with
here is that `adminClient.listConsumerGroups()` sounds like it actually returns
groups of all kinds, but that's misleading. The result might contain groups
which are not consumer groups and if you attempt consumer group operations on
them, you'll get errors. It should return consumer groups.
Obviously, there's some history here and the transition as the new consumer
group protocol and the new group types are introduced has a few rough edges
because these were not ideas that were anticipated a few years ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
