lianetm commented on code in PR #17150:
URL: https://github.com/apache/kafka/pull/17150#discussion_r1825837984
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -187,22 +188,62 @@ private void process(final CreateFetchRequestsEvent
event) {
private void process(final AsyncCommitEvent event) {
Review Comment:
hey @FrankYang0529 . I cannot see any undesired side-effect, and the change
actually makes sense to keep the committed offsets related logic in the
commitRequestManager.
I expect we just need to pass the `metadata` object into the commit manager
constructor (it's already available in RequestManagers), and ensure that the
commit mgr calls the `maybeUpdateLastSeenEpochIfNewer` from the
`fetchCommitted`, `commitSync` and `commitAsync` (exactly how it's now done in
the appEventProcessor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
