lianetm commented on code in PR #17150:
URL: https://github.com/apache/kafka/pull/17150#discussion_r1831279504
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -198,27 +198,39 @@ private void process(final CreateFetchRequestsEvent
event) {
}
private void process(final AsyncCommitEvent event) {
- if (!requestManagers.commitRequestManager.isPresent()) {
+ if (requestManagers.commitRequestManager.isEmpty()) {
+ event.future().completeExceptionally(new KafkaException("Unable to
async commit " +
+ "offset because the CommittedRequestManager is not available.
Check if group.id was set correctly"));
Review Comment:
typo: CommitRequestManager
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -198,27 +198,39 @@ private void process(final CreateFetchRequestsEvent
event) {
}
private void process(final AsyncCommitEvent event) {
- if (!requestManagers.commitRequestManager.isPresent()) {
+ if (requestManagers.commitRequestManager.isEmpty()) {
+ event.future().completeExceptionally(new KafkaException("Unable to
async commit " +
+ "offset because the CommittedRequestManager is not available.
Check if group.id was set correctly"));
return;
}
- CommitRequestManager manager =
requestManagers.commitRequestManager.get();
- CompletableFuture<Void> future = manager.commitAsync(event.offsets());
- future.whenComplete(complete(event.future()));
+ try {
+ CommitRequestManager manager =
requestManagers.commitRequestManager.get();
+ CompletableFuture<Map<TopicPartition, OffsetAndMetadata>> future =
manager.commitAsync(event.offsets());
+ future.whenComplete(complete(event.future()));
+ } catch (Exception e) {
+ event.future().completeExceptionally(e);
+ }
}
private void process(final SyncCommitEvent event) {
- if (!requestManagers.commitRequestManager.isPresent()) {
+ if (requestManagers.commitRequestManager.isEmpty()) {
+ event.future().completeExceptionally(new KafkaException("Unable to
sync commit " +
+ "offset because the CommittedRequestManager is not available.
Check if group.id was set correctly"));
Review Comment:
typo: CommitRequestManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
