FrankYang0529 commented on PR #17150: URL: https://github.com/apache/kafka/pull/17150#issuecomment-2453455270
Hi @lianetm / @kirktrue, thanks for the review and suggestion. I do following change: * Move offsets option checking and `maybeUpdateLastSeenEpochIfNewer` to `CommitRequestManager`. * Move related test cases from `ApplicationEventProcessorTest` to `CommitRequestManagerTest`. * Remove unnecessary `completeCommitSyncApplicationEventSuccessfully` from `AsyncKafkaConsumerTest`. * Update `testAutoCommitSyncDisabled` to call `close` explicitly. * Change `testAutoCommitSyncEnabled` to `testCommitSyncAllConsumed`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
