lianetm commented on code in PR #17150:
URL: https://github.com/apache/kafka/pull/17150#discussion_r1829839607
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -198,23 +198,47 @@ private void process(final CreateFetchRequestsEvent
event) {
}
private void process(final AsyncCommitEvent event) {
- if (!requestManagers.commitRequestManager.isPresent()) {
+ if (requestManagers.commitRequestManager.isEmpty()) {
+ event.future().complete(Map.of());
Review Comment:
uhm I would leave it out of this PR. Even though there are some other
process calls that should probably fail if the expected manager is not present,
in some we shouldn't fail and just return/no-op as they do now (ie.
commitOnClose no-op if no commit mgr, triggered from close regardless of
groupId present or not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
