TaiJuWu commented on code in PR #18196:
URL: https://github.com/apache/kafka/pull/18196#discussion_r1896768793
##########
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##########
@@ -48,6 +51,11 @@ class DynamicClientQuotaPublisher(
): Unit = {
val deltaName = s"MetadataDelta up to
${newImage.highestOffsetAndEpoch().offset}"
try {
+ val clientQuotaCallback =
conf.getConfiguredInstance(QuotaConfig.CLIENT_QUOTA_CALLBACK_CLASS_CONFIG,
classOf[ClientQuotaCallback])
+ if (clientQuotaCallback != null) {
Review Comment:
https://github.com/apache/kafka/blob/6836fa259e0c50cc6a8d5099b3fbbacda9c2aadc/core/src/main/scala/kafka/server/ClientQuotaManager.scala#L151
Here will initialize to `DefaultQuotaCallback ` if my understand is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
