m1a2st commented on code in PR #18196:
URL: https://github.com/apache/kafka/pull/18196#discussion_r1896774619
##########
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##########
@@ -48,6 +51,11 @@ class DynamicClientQuotaPublisher(
): Unit = {
val deltaName = s"MetadataDelta up to
${newImage.highestOffsetAndEpoch().offset}"
try {
+ val clientQuotaCallback =
conf.getConfiguredInstance(QuotaConfig.CLIENT_QUOTA_CALLBACK_CLASS_CONFIG,
classOf[ClientQuotaCallback])
+ if (clientQuotaCallback != null) {
Review Comment:
Hmm, user should set this config in the server, it will have the not null
value, user also can extend the `DefaultQuotaCallback` and override the method,
make sense?
https://github.com/apache/kafka/blob/5a4590c02016faeea3adeadb0d53e4388a558096/server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java#L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
