sjhajharia commented on code in PR #18571: URL: https://github.com/apache/kafka/pull/18571#discussion_r1918514827
########## clients/src/main/java/org/apache/kafka/common/requests/ReadShareGroupStateSummaryRequest.java: ########## @@ -83,8 +84,24 @@ public ReadShareGroupStateSummaryRequestData data() { public static ReadShareGroupStateSummaryRequest parse(ByteBuffer buffer, short version) { return new ReadShareGroupStateSummaryRequest( - new ReadShareGroupStateSummaryRequestData(new ByteBufferAccessor(buffer), version), - version + new ReadShareGroupStateSummaryRequestData(new ByteBufferAccessor(buffer), version), + version ); } + + public static List<ReadShareGroupStateSummaryResponseData.ReadStateSummaryResult> getErrorList( + List<Uuid> topicIds, + Errors error + ) { + return topicIds.stream() + .map(topicId -> + new ReadShareGroupStateSummaryResponseData.ReadStateSummaryResult() + .setTopicId(topicId) + .setPartitions(List.of( + new ReadShareGroupStateSummaryResponseData.PartitionResult() + .setErrorCode(error.code()) + .setErrorMessage(error.exceptionName()) Review Comment: Yes, I agree, the actual error would make more sense. Making the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org