sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918539274
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -730,6 +734,147 @@ protected RPCType rpcType() {
}
}
+ public class ReadStateSummaryHandler extends PersisterStateManagerHandler {
+ private final int leaderEpoch;
+ private final CompletableFuture<ReadShareGroupStateSummaryResponse>
result;
+ private final BackoffManager readStateSummaryBackoff;
+
+ public ReadStateSummaryHandler(
+ String groupId,
+ Uuid topicId,
+ int partition,
+ int leaderEpoch,
+ CompletableFuture<ReadShareGroupStateSummaryResponse> result,
+ long backoffMs,
+ long backoffMaxMs,
+ int maxRPCRetryAttempts,
+ Consumer<ClientResponse> onCompleteCallback
+ ) {
+ super(groupId, topicId, partition, backoffMs, backoffMaxMs,
maxRPCRetryAttempts);
+ this.leaderEpoch = leaderEpoch;
+ this.result = result;
+ this.readStateSummaryBackoff = new
BackoffManager(maxRPCRetryAttempts, backoffMs, backoffMaxMs);
+ }
+
+ public ReadStateSummaryHandler(
+ String groupId,
+ Uuid topicId,
+ int partition,
+ int leaderEpoch,
+ CompletableFuture<ReadShareGroupStateSummaryResponse> result,
+ Consumer<ClientResponse> onCompleteCallback
+ ) {
+ this(
+ groupId,
+ topicId,
+ partition,
+ leaderEpoch,
+ result,
+ REQUEST_BACKOFF_MS,
+ REQUEST_BACKOFF_MAX_MS,
+ MAX_FIND_COORD_ATTEMPTS,
+ onCompleteCallback
+ );
+ }
+
+ @Override
+ protected String name() {
+ return "ReadStateSummaryHandler";
+ }
+
+ @Override
+ protected AbstractRequest.Builder<ReadShareGroupStateSummaryRequest>
requestBuilder() {
+ throw new RuntimeException("Read Summary requests are batchable,
hence individual requests not needed.");
Review Comment:
This too is based on the error as seen in the
[WriteStateHandler](https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java#L497-L499)
and
[ReadStateHandler](https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java#L641-L643).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
