sjhajharia commented on code in PR #18571: URL: https://github.com/apache/kafka/pull/18571#discussion_r1918529558
########## server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java: ########## @@ -288,7 +291,96 @@ public CompletableFuture<DeleteShareGroupStateResult> deleteState(DeleteShareGro * @return A completable future of ReadShareGroupStateSummaryResult */ public CompletableFuture<ReadShareGroupStateSummaryResult> readSummary(ReadShareGroupStateSummaryParameters request) { - throw new RuntimeException("not implemented"); + try { + validate(request); + } catch (Exception e) { + log.error("Unable to validate read state summary request", e); Review Comment: I am not sure about the severity here. I have tried to maintain consistency here with the [readShare()](https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java#L177-L183) and [writeShare()](https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java#L81-L86) methods in the same class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org