sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918582979
##########
clients/src/main/java/org/apache/kafka/common/requests/ReadShareGroupStateSummaryRequest.java:
##########
@@ -34,7 +35,7 @@ public static class Builder extends
AbstractRequest.Builder<ReadShareGroupStateS
private final ReadShareGroupStateSummaryRequestData data;
public Builder(ReadShareGroupStateSummaryRequestData data) {
- this(data, false);
+ this(data, true);
Review Comment:
Yes, this change seems almost inevitable. The `PersisterStateManager` class
has the freshly introduced `coalesceReadSummarys()` method which generated the
`ReadShareGroupStateSummaryRequest`. If we keep it as false, this request will
not reach the broker as the latest version is unstable.
For the
[ReadShareGroupState](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/ReadShareGroupStateRequest.java#L36-L38)
and
[WriteShareGroupState](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/WriteShareGroupStateRequest.java#L36-L39)
too, it has been set to true.
The version can be passed in the `.build()` method as is the case with
ShareFetchRequest and ShareAcknowledge, however, for both of these, the tests
lie in the KafkaApisTest where as you mentioned, they override the property
using `ServerConfigs.UNSTABLE_API_VERSIONS_ENABLE_CONFIG -> "true"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
