mjsax commented on code in PR #18722:
URL: https://github.com/apache/kafka/pull/18722#discussion_r1933227735
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -906,13 +910,14 @@ private KStreamImpl<K, V> repartitionForJoin(final String
repartitionName,
builder);
}
- static <K1, V1, RN extends BaseRepartitionNode<K1, V1>> String
createRepartitionedSource(final InternalStreamsBuilder builder,
-
final Serde<K1> keySerde,
-
final Serde<V1> valueSerde,
-
final String repartitionTopicNamePrefix,
-
final StreamPartitioner<K1, V1> streamPartitioner,
-
final BaseRepartitionNodeBuilder<K1, V1, RN>
baseRepartitionNodeBuilder) {
-
+ static <KStream, VStream, RepartitionNode extends
BaseRepartitionNode<KStream, VStream>> String createRepartitionedSource(
+ final InternalStreamsBuilder builder,
Review Comment:
Oh. I see the confusing. My bad. Not a good name... I just meant `Key type
of a Stream`... `K1` is just terrible...
Re-using `<K,V>` even if possible, would imply shadowing the `KStream<K,V>`
generics... (what might be ok, as we don't need access to them, but it's not
recommended in general, but we should use a different name.
Any ideas for a good name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
