mjsax commented on code in PR #18722:
URL: https://github.com/apache/kafka/pull/18722#discussion_r1933228062
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -1103,26 +1108,28 @@ public <KG, VG, VR> KStream<K, VR> leftJoin(final
GlobalKTable<KG, VG> globalTab
return globalTableJoin(globalTable, keySelector, joiner, true, named);
}
- private <KG, VG, VR> KStream<K, VR> globalTableJoin(final GlobalKTable<KG,
VG> globalTable,
- final KeyValueMapper<?
super K, ? super V, ? extends KG> keySelector,
- final
ValueJoinerWithKey<? super K, ? super V, ? super VG, ? extends VR> joiner,
- final boolean leftJoin,
- final Named named) {
+ private <KGlobalTable, VGlobalTable, VOut> KStream<K, VOut>
globalTableJoin(
Review Comment:
Guess it's the same question as above -- we might want to use some different
name to begin with. Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
