mjsax commented on code in PR #18722:
URL: https://github.com/apache/kafka/pull/18722#discussion_r1933226376
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -248,9 +248,9 @@ public <KR, VR> KStream<KR, VR> map(final KeyValueMapper<?
super K, ? super V, ?
Objects.requireNonNull(named, "named can't be null");
final String name = new
NamedInternal(named).orElseGenerateWithPrefix(builder, MAP_NAME);
- final ProcessorParameters<? super K, ? super V, ?, ?>
processorParameters =
+ final ProcessorParameters<K, V, KR, VR> processorParameters =
Review Comment:
For `map()` we know that the output types are `KR` and `VR` -- so why should
we leave them unchecked as `?` -- we know the types and the compiler can verify
them for us.
I believe, we did use `?` to work with the old PAPI which did not have
output types on `Processor` interface, but know we can improve type safety by
enforcing the check now, as we have the new `api.Processor` interface in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
