mjsax commented on code in PR #18722:
URL: https://github.com/apache/kafka/pull/18722#discussion_r1934549683


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -906,13 +910,14 @@ private KStreamImpl<K, V> repartitionForJoin(final String 
repartitionName,
             builder);
     }
 
-    static <K1, V1, RN extends BaseRepartitionNode<K1, V1>> String 
createRepartitionedSource(final InternalStreamsBuilder builder,
-                                                                               
              final Serde<K1> keySerde,
-                                                                               
              final Serde<V1> valueSerde,
-                                                                               
              final String repartitionTopicNamePrefix,
-                                                                               
              final StreamPartitioner<K1, V1> streamPartitioner,
-                                                                               
              final BaseRepartitionNodeBuilder<K1, V1, RN> 
baseRepartitionNodeBuilder) {
-
+    static <KStream, VStream, RepartitionNode extends 
BaseRepartitionNode<KStream, VStream>> String createRepartitionedSource(
+        final InternalStreamsBuilder builder,

Review Comment:
   Yes. Cf https://github.com/apache/kafka/pull/18721#discussion_r1934537661 -- 
Same question... Any ideas?
   
   We cannot just use `Key`, and `Value` there... 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to